This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
user friendly image loading #7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Sep 21, 2017
src/io/image_io.cc
Outdated
| } else { | ||
| dst = cv::Mat(out->shape()[0], out->shape()[1], flag == 0 ? CV_8U : CV_8UC3, | ||
| out->data().dptr_); | ||
| #if (CV_MAJOR_VERSION > 2 || (CV_MAJOR_VERSION == 2 && CV_MINOR_VERSION >=4)) | ||
| cv::imdecode(buf, flag, &dst); | ||
| CHECK(!dst.empty()) << "Failed decoding image to output directly."; |
There was a problem hiding this comment.
Decoding failed. Invalid image file.
piiswrong
reviewed
Sep 21, 2017
src/io/image_io.cc
Outdated
| #else | ||
| cv::Mat tmp = cv::imdecode(buf, flag); | ||
| CHECK(!tmp.empty()); | ||
| CHECK(!tmp.empty()) << "Invalid image file. Only supports png and jpg."; |
There was a problem hiding this comment.
Decoding failed. Invalid image file.
|
please fix lint |
fix modify log message fix pylint
zhreshold
force-pushed
the
io-better-log
branch
from
31213c8
to
7b5cfd2
Compare
szha
approved these changes
Sep 23, 2017
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 25, 2017
fix modify log message fix pylint
crazy-cat
pushed a commit
to crazy-cat/incubator-mxnet
that referenced
this pull request
Oct 26, 2017
fix modify log message fix pylint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7958