License fixes #8873
License fixes #8873
Conversation
|
mshadow and nnvm are not apache projects. They don't need this header |
|
So which ones do? We got a downvote by Apache on the release due to problems with licensing headers in files in these modules. |
|
It would help if some dmlc people got on general@ and dispute these issues rather than just Apache committers try to make a case for dmlc people's wishes and restrictions. |
|
We should solve this by not including any 3rdparty source code in the release tar. |
docs/_static/searchtools_custom.js
Outdated
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| /* | ||
| * searchtools.js_t | ||
| * ~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
During 0.11.0 release there was a comment to remove the asf header from this file and I did this here - #8247
* Remove ASF Licenses from some files * typo * typo 2 * whitelisting files for header check
cjolivier01
force-pushed
the
v1.0.0.rc1
branch
from
61e0baa
to
8b5b120
Compare
|
Looks ok to me. |
|
Right, no submodule changes are being merged. |
|
As suggested, I will move cub to 3rdparty in another PR |
| @@ -234,7 +237,7 @@ | |||
| 1. Fast R-CNN - For details, see example/rcnn/LICENSE | |||
| 2. Faster R-CNN - For details, see example/rcnn/LICENSE | |||
| 3. tree_lstm - For details, see example/gluon/tree_lstm/LICENSE | |||
|
|
|||
| 4. JQuery - For details, see http://jquery.org/license | |||
There was a problem hiding this comment.
You should include the actual license text in the package, since it could vary between releases of jquery. Use the same pointer file structure as other files mentioned in this section.
Description
(Brief description on what this PR is about)
Checklist
Essentials
make lint)Changes
Comments