Update PR Template #9919
Update PR Template #9919
Conversation
Could we add checkboxes to all items in the list?
|
I think the list items are intended as enumeration of possible situations. They usually don't apply all at once. |
+1 on sheng's comment |
Could we add a note that not applicable items should be removed from the description? It's sometimes hard to see the actual message between the default text lines |
Done |
@eric-haibin-lin would you add an item to remind the committers to check the API doc of the PR? See details in #9928. It should read like: |
@szha That is nice! Didn't know we were building API docs for each PR. |
Done |
Could we also add an item to remind people linking the JIRA issue? |
Done. Although I'm a little bit worried that all these reminders make the template kind of heavy |
Agree, we might have to do a proper cleanup of that template and make it more lightweight. |
* Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md
Removed code style checking from the template. It is checked by the CI anyway. No PR can be merged without passing this.