TOBAGO-1666 tc:selectBooleanCheckbox: itemLabel with accessKey #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the itemLabel and the accessKey are set, there is no label and the accessKey is contained in the itemLabel, then the itemLabel with the underlined accessKey should be written within one u-tag. Otherwise only the itemLabel is written
henningn
changed the title
henningn
requested changes
Mar 17, 2020
There was a problem hiding this comment.
Improve commit message. For example:
tc:selectBooleanCheckbox: itemLabel with accessKey
- The accessKey is shown on the label by default. But if only an itemLabel is set, the accessKey is shown on the itemLabel.
- itemLabel works also for tc:selectBooleanToggle
Issue: TOBAGO-1666
added 2 commits
March 18, 2020 09:11
The accessKey is shown on the label by default. But if only an itemLabel is set, the accessKey is shown on the itemLabel. itemLabel works also for tc:selectBooleanToggle Issue: TOBAGO-1666
…' into fixSelectBooleanCheckBoxRenderer
|
See: #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the itemLabel and the accessKey are set, there is no label and the accessKey is contained in the itemLabel, then the itemLabel with the underlined accessKey should be written within one u-tag. Otherwise only the itemLabel is written