MYFACE-4387: JSF to Faces in Javadoc and Constants #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We even cant merge it |
|
no problem i will close it |
|
Thanks for looking into this so quick.
Should I mark MYFACE-4387 as fixed in 4.0.0-RC1 then?
… On Jun 10, 2022, at 4:28 PM, Melloware ***@***.***> wrote:
no problem i will close it
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
This should be marked for 4.0.0-RC2 since it just recently got merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@volosied @tandraschko you definitely don't have to accept this but I renamed most JSF to Faces in Javadoc and Consttants. etc.
The one thing I did not touch is the Build Tools annotations like
@JSFComponent(name="ui:debug")etc since those build tools are still used across all versions.