Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYFACES-4442: Fix UnsupportedOperationException during Faces init #288

Conversation

pnicolucci
Copy link
Contributor

@pnicolucci pnicolucci commented Aug 24, 2022

This fixes MYFACES-4442: https://issues.apache.org/jira/browse/MYFACES-4442

I had to rummage around in the commit history of the current branches and find where these classes used to reside:

  1. ServletMapping
  2. WebXml I updated this class to correct javax->jakarta, ClassUtils current package, updated import for DelegatedFacesServlet, and updated package for WebXmlParser.
  3. WebXmlParser Already existed. History of WebXmlParser I added the following back to it and modified it as necessary to fit into the latest code base: This is what it looked like before it was moved in the same commit. The readWebApp method was updated to read the different mappings , which was removed here.
  4. WebXmlParserErrorHandler
  5. WebXmlParserUtils

@pnicolucci pnicolucci added the bug Something isn't working label Aug 24, 2022
@pnicolucci pnicolucci self-assigned this Aug 24, 2022
@pnicolucci pnicolucci force-pushed the FixUnsupportedOperationsExceptionFacesInit branch 4 times, most recently from 0d8b33b to 51f5128 Compare August 24, 2022 19:11
@pnicolucci pnicolucci marked this pull request as ready for review August 24, 2022 22:56
@pnicolucci pnicolucci force-pushed the FixUnsupportedOperationsExceptionFacesInit branch from 51f5128 to dddf4aa Compare August 25, 2022 01:26
@tandraschko
Copy link
Member

I think the fallback should be directly in FacesServletMappingUtils.getFacesServletRegistration

AFAICS we dont scan web-fragments? Thats a must have

@pnicolucci
Copy link
Contributor Author

@tandraschko I have another idea and I think we can avoid this web.xml parsing altogether. I'll work to get a new PR to share my findings and we can discuss.

@pnicolucci pnicolucci closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants