Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYFACES-4604: Update f:websocket integration message #576

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

pnicolucci
Copy link
Contributor

@pnicolucci pnicolucci self-assigned this Jun 9, 2023
@pnicolucci pnicolucci requested a review from volosied June 9, 2023 23:24
Copy link
Contributor

@volosied volosied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reads fine to me. You could specify the context to refer to servlet context, but that might not be necessary.

@pnicolucci
Copy link
Contributor Author

@volosied does this look better to you? I pushed up a change that uses ServletContext:

log.log(Level.INFO, "f:websocket support is enabled but the WebSocket ServerContainer instance " + "cannot be found in the current ServletContext.");

@pnicolucci pnicolucci requested a review from volosied June 10, 2023 22:38
Copy link
Contributor

@volosied volosied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@pnicolucci pnicolucci merged commit c52b5e9 into apache:main Jun 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants