Faces 5.0: MYFACES-4618: ui:repeat clarification on attributes, such as offset and size #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
force-pushed
the
MYFACES-4618
branch
4 times, most recently
from
49b80d6
to
62331fc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
melloware
force-pushed
the
MYFACES-4618
branch
7 times, most recently
from
603bd3b
to
bea5603
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
We should wait to merge this in: is should target 5.0 instead. See my comment here and BalcsC's reply: jakartaee/faces#1713 (comment) |
|
As for the TLD documentation, I think all it needs are javadoc comments in the getters? |
|
I will try the Java doc and see if it generates the TLD correctly. |
melloware
changed the title
tandraschko
changed the title
tandraschko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MYFACES-4618: 5.0: ui:repeat clarification on attributes, such as offset and size