MYFACES-4653: Remove SecurityManager and associated APIs [4.1]

[pnicolucci]

https://issues.apache.org/jira/browse/MYFACES-4653

1. I've removed all the references to the SecurityManager and associated APIs in both the API and IMPL code.
2. I've cleaned up the SPI in general to have more consistent naming conventions for some variables.
3. I removed one comment in DefaultFaceletFactory that didn't look to be necessary any longer.

Please give this one a good review to ensure I didn't miss anything as there are many changes.

[melloware]

So is AccessController.doPrivileged just completely not needed anymore in JDK17?

[pnicolucci]

So is AccessController.doPrivileged just completely not needed anymore in JDK17?

It is still in Java17 and accessible. One theme of Jakarta EE11 was to work on removing the references to the SecurityManager in anticipation of it being removed in a future Java version.

See the Faces 4.1 Spec issue here: jakartaee/faces#1838, you can see there are some references to the Mojarra code base that do similar cleanup

[melloware]

OK cool so this should be forward ported to 5.x once its accepted.

[pnicolucci]

OK cool so this should be forward ported to 5.x once its accepted.

@melloware I can create a PR for 5.x once I merge here. Let me add @tandraschko and @volosied as reviewers as well to make sure they don't have any comment and I'll plan to merge this on Monday if no further feedback!

Thanks for the quick review!

[volosied]

+1

Changes look good (code is so much cleaner now!)

Build locally and tested a small app -- everything looked to me.