hw/drivers/lis2dh12: Add sensor notifications support to LIS2DH12 driver #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bit fields were privet even though they were needed for functions settings registers with those fields.
This adds lis2dh12_write8 to simplify writes (no variable is needed to write simple valuse). This adds also lis2dh12_read8 for completeness.
- lis2dh12_clear_intX functions now return active interrupts - lis2dh12_enable_intX now value is passed by value not pointer - possible uninitialized variable now initialized
Added functions for click and activity registers.
Simple shell commands based on lis2dw12.
This adds support for sensors notifications with all required configuration to configure supported detection options in accel.
vrahane
changed the title
vrahane
requested changes
Oct 10, 2018
There was a problem hiding this comment.
So, the code looks fine, I see two main issues here:
- self test run is not implemented
- X,Y and Z notifications should be broken into X -> X_L and X_H and Y -> Y_L, Y_H and Z -> Z_L, Z_H. Please refer lis2dw12.c for the exact changes. I haven't really tested it but rest looks ok.
vrahane
reviewed
Oct 10, 2018
| @@ -34,6 +34,80 @@ | |||
| #include "modlog/modlog.h" | |||
| #include "stats/stats.h" | |||
| #include <syscfg/syscfg.h> | |||
| #include <sensor/sensor.h> | |||
| #include <console/console.h> | |||
There was a problem hiding this comment.
#include <console/console.h> should be removed
vrahane
requested changes
Oct 10, 2018
|
This was merged as part of #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos go to @kasjer - I just made few small fixes in few places and tested this :-)