Use generated sysdown() function #1447
Conversation
| int | ||
| sysdown(int reason, sysdown_complete_fn *complete_cb, void *arg) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
Should call complete_cb() here, otherwise hal_system_reset() will not get called.
There was a problem hiding this comment.
Yes, good catch.
| assert(rc == 0); | ||
|
|
||
| /* Call each configured sysdown callback. */ | ||
| for (i = 0; sysdown_cbs[i] != NULL; i++) { |
There was a problem hiding this comment.
Could it be sizeof(sysdown_cbs) / sizeof(sysdown_cbs[0])? Would save 4 bytes of text, if sysdown_cbs[] we're not terminated by a NULL...
There was a problem hiding this comment.
The reason I null-terminated the array is to handle the case where there aren't any sysdown procedures (a zero-length array being undefined). gcc does allow zero-length arrays, but I didn't think four bytes' savings justified using an extension.
sys/sysdown/src/sysdown.c
Outdated
| break; | ||
|
|
||
| default: | ||
| return SYS_EUNKNOWN; |
There was a problem hiding this comment.
I'm wondering if it would be better to continue calling sysdown() routines, and proceed with the shutdown?
There was a problem hiding this comment.
Yes, I agree. It doesn't make sense for sysdown to just stop like this.
ccollins476ad
force-pushed
the
sysdown
branch
from
f764a3d
to
7238b83
Compare
NOTE: This commit requires a newt tool update (dfaede5fbdd0c9d798714abed77b54be2d26bc06). Upon application-triggered restart, execute each package's shutdown subprocedure. This feature is discussed here: https://lists.apache.org/thread.html/ebd53c9b56230184650ea57e5534d5bcfbfc170b97547a1a26f100b5@%3Cdev.mynewt.apache.org%3E
ccollins476ad
force-pushed
the
sysdown
branch
from
7238b83
to
9ee0f63
Compare
|
Thanks, @mkiiskila. I believe I have addressed all your comments as follows:
Also, I changed the syscfg setting name from |
NOTE: This commit requires a newt tool update (a38614ebc22959231ad9597c24467e34ed0e5068).
Upon application-triggered restart, execute each package's shutdown subprocedure. This feature is discussed here:
https://lists.apache.org/thread.html/ebd53c9b56230184650ea57e5534d5bcfbfc170b97547a1a26f100b5@%3Cdev.mynewt.apache.org%3E