nrf52: Make target MCU and LFCLK source selection as a choice #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would require a new version of newt to build *-core, correct? We should probably upgrade the satisfies dependency for newt. |
andrzej-kaczmarek
force-pushed
the
nrf52-syscfg-choice
branch
from
c83a06b
to
c808e0d
Compare
|
dependency for newt will be updated for next release |
|
master is expected to be used with master newt |
sjanc
approved these changes
Mar 8, 2019
andrzej-kaczmarek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposed change to use choice settings to select target MCU and LFCLK source for nRF52xxx BSP-s. It requires new
newtfeature implemented here: apache/mynewt-newt#270. The advantage here is that we do not need separate values for each option andnewtwill take care of proper value being set for those settings (and there will be only one value). The disadvantage is that it breaks compatibility with earliernewtversion and possible with some external code that uses those settings.