hw/ipc_nrf5340: (Re-)Fix enabling GPIO passing to network core #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with both approaches, the macro approach preferred. Thank you for pushing this again. |
vrahane
approved these changes
Jun 29, 2021
sjanc
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outcome of #2629 used a bitmask to set which GPIOs the application core handed over to the networking core.
This made for neat code but complicated the syscfg handling.
This PR undoes #2629, the bitmask change, and uses preprocessor magic to accomplish the same with a simple comma separated syscfg value for specifying pins.
Feedback welcome again, and this time I'll hang out for consensus before merging.