New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
da1469x: hal_flash: Autodetect and configure flash #2827
Merged
agross-korg
merged 8 commits into
apache:master
from
agross-korg:da146x-flash-autoconfig
May 23, 2022
Merged
da1469x: hal_flash: Autodetect and configure flash #2827
agross-korg
merged 8 commits into
apache:master
from
agross-korg:da146x-flash-autoconfig
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds in autodetection and configuration of Gigadevice and Macronix flash devices based on the manufacturer and device ID. The intent in this is to allow for a single binary to work on devices with different flash. Signed-off-by: Andy Gross <andy.gross@juul.com>
kasjer
reviewed
May 4, 2022
This patch moves the rdid structure to the BSP. The default structure will be a empty array. Extern references are used to access the array and its size. Signed-off-by: Andy Gross <andy.gross@juul.com>
Signed-off-by: Andy Gross <andy.gross@juul.com>
kasjer
reviewed
May 18, 2022
Signed-off-by: Andy Gross <andy.gross@juul.com>
This patch fixes build breakage after moving the rdids to the BSP vs MCU. Signed-off-by: Andy Gross <andy.gross@juul.com>
Signed-off-by: Andy Gross <andy.gross@juul.com>
Signed-off-by: Andy Gross <andy.gross@juul.com>
Signed-off-by: Andy Gross <andy.gross@juul.com>
Style check summaryNo suggestions at this time! |
kasjer
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JustineKH
pushed a commit
to JuulLabs/mynewt-core
that referenced
this pull request
Jul 8, 2022
da146x: hal_flash: Autodetect and configure flash This patch adds in autodetection and configuration of Gigadevice and Macronix flash devices based on the manufacturer and device ID. The intent in this is to allow for a single binary to work on devices with different flash. Signed-off-by: Andy Gross <andy.gross@juul.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds in auto-detection and configuration of Gigadevice and Macronix
flash devices based on the manufacturer and device ID. The intent in this is to
allow for a single binary to work on devices with different flash.
Normally, the flash is initialized by the ROM bootloader on the device. However, if the image being loaded is RAM_RESIDENT, that header will not exist and the ROM bootloader will not provision the device to have a working flash configuration.
Signed-off-by: Andy Gross andy.gross@juul.com