Add ETH support to PIC32 boards #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kasjer
commented
Sep 29, 2022
kasjer
commented
- pic32mz_periph_create() now creates eth device if ETH_0 is specified
- olimex-pic32-hmz144 now includes config settings for RMII/MII
- olimex-pic32-emz64 includes RMII settings and also gets configuration for on-bard LAN8710 (interrupt pin, and reset pin)
sjanc
requested changes
Sep 30, 2022
| #if MYNEWT_VAL(ETH_0) | ||
| int rc; | ||
| rc = pic32_eth_init(ð0_cfg); | ||
| assert(0); |
There was a problem hiding this comment.
this looks odd, assert(rc == 0) maybe?
There was a problem hiding this comment.
Polishing before commit not always works as intended.
Fixed.
pic32mz_periph_create() now can create ETH device if ETH_0 is set.
Add configuration for ethernet driver
Change adds config options for ethernet.
kasjer
force-pushed
the
kasjer/pic32-bsp-add-eth
branch
from
0a93bdf
to
3a7af81
Compare
Style check summaryNo suggestions at this time! |
sjanc
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.