loramac: fix broken rx1 interval #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkucera
force-pushed
the
fix-lora-join1
branch
from
d63b93e
to
23453f5
Compare
danielkucera
changed the title
danielkucera
force-pushed
the
fix-lora-join1
branch
from
23453f5
to
7418722
Compare
Style check summaryNo suggestions at this time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lora_mac_process_radio_rx_timeoutis called fromlora_mac_process_rx_win2_timeoutwhich is triggered when RX2/join2 window starts. The problem here is that there still can be unfinished rx1 window downlink transmission (delay between rx1 and rx2 window start is fixed to 1sec and the message air time can be longer).In that case, we don't want to put radio to sleep - that would cancel the receive and the message would be dropped