pic32 use spi_hal bus driver for SPI #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was pic32 specific mips_spi_cfg struct for SPI pins. Now SPI for pic32 uses common hal defined structure and hal_spi_init_hw function is added so bus driver spi_hal can be used.
If bus driver is present function pic32mz_periph_spi_devs() creates SPI devices. This also adds hal_spi_init_hw function needed by spi_hal.
sjanc
approved these changes
Mar 21, 2023
| hal_spi_init_hw(uint8_t spi_num, uint8_t spi_type, | ||
| const struct hal_spi_hw_settings *cfg) | ||
| { | ||
| return hal_spi_init(spi_num, (void *)cfg, spi_type); |
There was a problem hiding this comment.
nitpick: maybe cast to const void * ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simple refactor of hal_spi so it can be used with spi_hal bus driver.
When bus driver bus/drivers/spi_hal is added to the target pic32mz_periph_create() function creates proper devices
so applications using bus driver interface can be built.