hw/drivers/mmc: Fix Multiple Block Read CMD18 #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multiply block read control token and CRC is send for each block not just the first one. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
kasjer
force-pushed
the
kasjer/mmc-fixes
branch
2 times, most recently
from
d7ed322
to
94ea8e9
Compare
sjanc
approved these changes
Jul 13, 2023
hw/drivers/mmc/src/mmc.c
Outdated
| mmc->ss_pin = ss_pin; | ||
| mmc->spi_cfg = spi_cfg; | ||
| mmc->settings = &mmc_settings; | ||
| mmc->mmc_spi_cfg = *(struct mmc_spi_cfg *)spi_cfg; |
There was a problem hiding this comment.
nitpick: this cast is no longer needed (as spi_cfg is not void * anymore)
Baudrate for mmc was hardcoded to 125kHz to work with NRF5x. mmc_init had spi_cfg parameter that was of type void * and was not used. Now this parameter is of type mmc_spi_cfg that specifies both initial baudrate and higher speed baudrate and also clock phase which turns out that can be other then MODE0. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: