Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hw/mcu/dialog: added critical section to dma acquire peripheral #3084

Closed
wants to merge 1 commit into from
Closed

hw/mcu/dialog: added critical section to dma acquire peripheral #3084

wants to merge 1 commit into from

Conversation

dustinfranco
Copy link
Contributor

No description provided.

wes3
wes3 requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@wes3 wes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this needs a change to the commit message. The commit message should have as the title: hw/mcu/dialog: <title> and not FWW-xxx in it.

@dustinfranco dustinfranco changed the title [FWW-262] added critical section to dma acquire peripheral hw/mcu/dialog: added critical section to dma acquire peripheral Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wes3 wes3 wes3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dustinfranco @wes3