BLE Host - Don't persist security material if either key distribution field is 0 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccollins476ad
changed the title
sjanc
requested changes
Jul 3, 2017
In legacy mode, if either peer indicates a key distribution flags value of 0, then don't persist security material when pairing completes. It isn't clear from the spec what should happen when both peers indicate bonding support, but one indicates a 0 key distribution field. I think proceding with pairing and just not persisting makes the most sense. This is also what Lightblue (or CoreBluetooth, I guess) seems to do.
|
Thanks, Szymon. That is a good catch. I have updated the original commit with a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is documented in: https://issues.apache.org/jira/browse/MYNEWT-749
This commit implements the following behavior:
If either peer indicates a key distribution flags value of 0, then don't persist security material when pairing completes.
It isn't clear from the spec what should happen when both peers indicate bonding support, but one indicates a 0 key distribution field. I think proceding with pairing and just not persisting makes the most sense. This is also what Lightblue (or CoreBluetooth, I guess) seems to do.