Convert some defines in bsp.h
to syscfg settings
#499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts a number of
#define
s in each BSP'sbsp.h
file to syscfg settings. The motivation for this change was to simplify thebsp.h
files for the purposes of documentation. I think this change is also desirable for these reasons:Reduce code duplication: several of these settings were defined with the same value in each BSP. Now these settings are defined once in one place.
Better modularity: each of these settings are used by a single package. It is better to define the setting in the package that needs it and allow the BSP to override it.
More opportunities to override: syscfg settings can be overridden by the BSP, app, and / or target, unlike
#define
s.The following syscfg settings are added: