BLE Host - Don't crash if no store package. #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymanluk
reviewed
Dec 19, 2017
| @@ -313,7 +313,7 @@ ble_hs_sync(void) | |||
|
|
|||
| if (rc == 0) { | |||
| rc = ble_hs_misc_restore_irks(); | |||
| assert(rc == 0); | |||
There was a problem hiding this comment.
Maybe we could add some info log saying that storage is not present?
There was a problem hiding this comment.
Thanks @rymanluk. I agree that we should log something on failure. I also think the assert() is a bit extreme, so I changed the code to log on failure but never crash.
Prior to this change: the host asserted that IRK restoration succeeds at sync time. A common reason for failure was the lack of any host store package in the build. After change: If IRK restoration at startup fails for any reason, a message is logged and the app continues running.
ccollins476ad
force-pushed
the
ble-hs-no-store
branch
from
4be2600
to
3e6ff4d
Compare
rymanluk
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change: the host asserted that IRK restoration succeeds at sync time.
After change: If IRK restoration at startup fails because there is no store package present, don't crash.