Feature/blecsc app: Cycling Speed and Cadence app #819
Conversation
Added example implementation of BLE Cycling Speed and Cadence simulated sensor.
Fixed header-guard define.
|
One comment. I did not figure out how to implement one SC control point requirement: "(...)Collector writes an Op Code to the SC Control Point while the SC Control Point It is fairly easy to check if indication is configured. But I could not find appropriate error code and I'm not sure what is the right way to pass ATT error response in such case. |
Sensor location opcodes handled by SC control point only if multiple sensor locations feature is enabled.
apps/blecsc/pkg.yml
Outdated
| - net/nimble/host/services/gap | ||
| - net/nimble/host/services/gatt | ||
| - net/nimble/host/store/config | ||
| - net/nimble/transport/ram |
There was a problem hiding this comment.
use net/nimble/transport package instead - this way other transport can be configured via syscfg setting without need to change app code (useful for sample apps since they may be run on different targets)
(see 2e59449 for reference)
apps/blecsc/src/gatt_svr.c
Outdated
| }; | ||
|
|
||
| static void | ||
| store_le32_as_u8_arr(uint32_t val, uint8_t * arr) |
There was a problem hiding this comment.
os/endian.h already defines get/put for le16, le32 and le64
| @@ -37,6 +37,8 @@ struct ble_hs_cfg; | |||
|
|
|||
| const char *ble_svc_gap_device_name(void); | |||
| int ble_svc_gap_device_name_set(const char *name); | |||
| int ble_svc_gap_device_appearance(void); | |||
| int ble_svc_gap_device_appearance_set(const uint16_t appearance); | |||
There was a problem hiding this comment.
I'd actually make this a syscfg value (BLE_SVC_GAP_APPEARANCE)
the reason for this is that appearance is read-only so it cannot (and should not) be changed in runtime.
getter is ok though.
apps/blecsc/src/main.c
Outdated
|
|
||
| case BLE_GAP_EVENT_ADV_COMPLETE: | ||
| BLECSC_LOG(INFO, "adv complete\n"); | ||
| blecsc_advertise(); |
There was a problem hiding this comment.
CSCP does not allow concurrent connections to single sensor so we should not restart advertising here - only after disconnection and failed connection
There was a problem hiding this comment.
Fair enough.
The spec is a bit ambiguous: "2.3 (...) There are no concurrency limitations or restrictions for the Collector and CSC Sensor roles imposed by this profile."
There was a problem hiding this comment.
This means a device can implement different roles concurrently so it ca be both a sensor and a collector, which probably does not make sense, but iirc only a handful of profiles impose any concurrency restrictions only if necessary (like HoGP).
CSC profile specific ATT error added. Custom endianness handling functions replaced with system functions. Device appearance moved to syscfg.
|
Looks good to me after changes, thanks! |
Added a new example BLE app implementing Cycling Speed and Cadence service.
The app was build from blehr app and may have inherited some issues. I consider implementation of Cycling Power sample app as well after this.
Tested with Polar V650.