add driver for ADXL345 sensor #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkiiskila
requested changes
Feb 21, 2018
|
|
||
| #include "defs/error.h" | ||
| #include "os/os.h" | ||
| #include "sysinit/sysinit.h" |
There was a problem hiding this comment.
Move this line a bit higher. There are syscfg settings which impact how includes from os/os.h are read in.
There was a problem hiding this comment.
I will sort the requested changes. I should also be able to add in IRQ bits, I mostly haven't done that yet as I wasn't sure how to implement it yet.
|
Sounds good. Support for thresholds and tap detection are quite useful in the Sensor API. |
vrahane
approved these changes
Feb 27, 2018
mkiiskila
approved these changes
Feb 28, 2018
aditihilbert
added
enhancement
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.