MYNEWT-860 Newt - Empty pkg.yml
issues.
#105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Jira ticket: https://issues.apache.org/jira/browse/MYNEWT-860)
Specifically, an empty
pkg.yml
file causes problems because it describes a package with no name. When there is a package whose name is""
, it matches some unset settings. In this case, the target being built does not specify a target.loader value, as it is not a split image. However, newt thinks the target actually specifies the unnamed packages as its loader, so it attempts to build a split image.The fix is to ignore packages with no name (and warn the user).