Newt - Don't display warning on initial install. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkiiskila
approved these changes
Feb 2, 2018
`newt new proj && cd proj && newt install` produced the following warning: ``` * Warning: failed to read repo "apache-mynewt-core": open /Users/ccollins/proj/repos/apache-mynewt-core: no such file or directory ``` It isn't surprising that newt failed to read the repo; it hadn't been installed yet! Now newt only reports a failure to read a repo if the repo has been installed, i.e., if the repo is present in the `project.state` file.
ccollins476ad
force-pushed
the
init-warn
branch
from
20526cb
to
0795b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newt new proj && cd proj && newt installproduced the following warning:It isn't surprising that newt failed to read the repo; it hadn't been installed yet!
Now newt only reports a failure to read a repo if the repo has been installed, i.e., if the repo is present in the
project.statefile.