imgprod: Close .img before passing it to objcopy #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccollins476ad
force-pushed
the
win-objcopy-fix
branch
from
fc4161c
to
751c471
Compare
ccollins476ad
changed the title
This fixes a bug in the Windows port of newt. Newt produces a .hex file by running `objcopy` on the .img file. It was doing this immediately after creating the .img file, before closing it. In Windows, objcopy cannot open a file when it is already open by a different process, so the command fails. The fix is to close the .img file before executing objcopy.
ccollins476ad
force-pushed
the
win-objcopy-fix
branch
from
751c471
to
2355c76
Compare
sjanc
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the Windows port of newt.
Newt produces a .hex file by running
objcopyon the .img file. It was doing this immediately after creating the .img file, before closing it. In Windows, objcopy cannot open a file when it is already open by a different process, so the command fails.The fix is to close the .img file before executing objcopy.