Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run: Fix options parsing for newt run #393

Merged
merged 1 commit into from Apr 8, 2020
Merged

run: Fix options parsing for newt run #393

merged 1 commit into from Apr 8, 2020

Conversation

vrahane
Copy link
Contributor

@vrahane vrahane commented Apr 7, 2020

  • Fixing parsing of encryption filenames and options for the run command

ccollins476ad
ccollins476ad requested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ccollins476ad ccollins476ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Just one minor request: could you please run gofmt on run_cmds.go?

@vrahane
run: Fix options parsing for newt run
96dbf58 
- Fixing parsing of encryption filenames and options for the run command
@vrahane vrahane force-pushed the fix_newt_run_encrypted_images branch from 90ad3cc to 96dbf58 Compare April 8, 2020 02:30
@vrahane
Copy link
Contributor Author

vrahane commented Apr 8, 2020

@ccollins476ad Thanks, done

@vrahane vrahane merged commit 2623dad into apache:master Apr 8, 2020
@vrahane vrahane deleted the fix_newt_run_encrypted_images branch April 8, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccollins476ad ccollins476ad ccollins476ad requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrahane @ccollins476ad