Fix --imgfile option for the load command
#404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--imgfile` lets the user specify the image file to load rather than letting newt derive it from the target name. This option wasn't working properly. For the download scripts to load the specified file, the `BIN_BASENAME` environment variable needs to be set to the file's *base* (i.e., strip the `.img` extension). Prior to this commit, this environment variable wasn't being overridden at all. The effect was that the `--imgfile` option was ignored completely.
|
Thanks @mlaz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--imgfilelets the user specify the image file to load rather thanletting newt derive it from the target name.
This option wasn't working properly. For the download scripts to load
the specified file, the
BIN_BASENAMEenvironment variable needs to beset to the file's base (i.e., strip the
.imgextension).Prior to this commit, this environment variable wasn't being overridden
at all. The effect was that the
--imgfileoption was ignoredcompletely.