syscfg: Always use full repo name in syscfg.h defs #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI builds have either mynewt-core or mynewt-nimble used as local repository so the repo name is omitted in syscfg.h package defs. This causes build issues since defines do not match those generated in generic configuration, i.e. local project is used as local repo. To avoid issues in future we'll always use full repo name for defs in syscfg.h, this way those are stable regardless of repo location. Note: repository name for local repo is the project name and it overrides repository.yml name, if any.
sjanc
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds have either mynewt-core or mynewt-nimble used as local repository so the repo name is omitted in syscfg.h package defs. This causes build issues since defines do not match those generated in generic configuration, i.e. local project is used as local repo.
To avoid issues in future we'll always use full repo name for defs in syscfg.h, this way those are stable regardless of repo location.
Note: repository name for local repo is the project name and it overrides repository.yml name, if any.