MYNEWT-821 newtmgr - Try harder to recover from disconnect during image upload #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An image upgrade consists of two phases: 1. Erase slot 2. Upload image On nRF boards, both phases cause the processor to stall while flash is being accessed. Such stalls can cause any established BLE connections to terminate due to "supervision timeout." Currently, the newtmgr tool automatically recovers from a disconnect during the first phase (erase). However, it does not recover from such a disconnect during the upload phase. Newtmgr should be improved to use the same reconnect logic during the second phase that it already uses during the first phase.
|
Note: newtmgr needs to be revendored if / when this PR gets merged. |
mkiiskila
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://issues.apache.org/jira/browse/MYNEWT-821)
An image upgrade consists of two phases:
On nRF boards, both phases cause the processor to stall while flash is being accessed. Such stalls can cause any established BLE connections to terminate due to "supervision timeout."
Currently, the newtmgr tool automatically recovers from a disconnect during the first phase (erase). However, it does not recover from such a disconnect during the upload phase.
Newtmgr should be improved to use the same reconnect logic during the second phase that it already uses during the first phase.