MYNEWT-822 newtmgr - Native BLE - reconnect on immediate supervision timeout #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkiiskila
approved these changes
Aug 2, 2017
The first data packet to be exchanged over a BLE connection has a high probability of triggering a disconnect. The sending controller uses this packet to determine if the connection attempt was successful in the first place, and it does not get retried if it gets dropped. In the case of newtmgr, the first data packet gets sent during ATT MTU negotiation. The bhd (blehostd) transports recover from a disconnect during ATT MTU negotiation by reopening the session. The ble transports (native BLE) do not recover from such a disconnect. We should add the same recovery logic for the ble transports that has already been implemented for bhd.
ccollins476ad
force-pushed
the
bll-reconnect
branch
from
c36cbcd
to
eb2ca89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://issues.apache.org/jira/browse/MYNEWT-822)
The first data packet to be exchanged over a BLE connection has a high probability of triggering a disconnect. The sending controller uses this packet to determine if the connection attempt was successful in the first place, and it does not get retried if it gets dropped.
In the case of newtmgr, the first data packet gets sent during ATT MTU negotiation. The bhd (blehostd) transports recover from a disconnect during ATT MTU negotiation by reopening the session.
The ble transports (native BLE) do not recover from such a disconnect. We should add the same recovery logic for the ble transports that has already been implemented for bhd.