Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller/ble_ll_scan: For callouts number of ticks should be used #1010

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

vrahane
Copy link
Contributor

@vrahane vrahane commented Aug 10, 2021

  • For callouts number of ticks are used, not an absolute value in the future.

BEFORE

001674 [ts=13078120us, mod=100 level=1] scan: completed scan procedure delta=1674
001676 [ts=13093744us, mod=100 level=1] scan: restarted scan procedure
004662 [ts=36421848us, mod=100 level=1] scan: completed scan procedure delta=2986
004664 [ts=36437472us, mod=100 level=1] scan: restarted scan procedure
010638 [ts=83109368us, mod=100 level=1] scan: completed scan procedure delta=5974
010640 [ts=83124992us, mod=100 level=1] scan: restarted scan procedure
022590 [ts=176484344us, mod=100 level=1] scan: completed scan procedure delta=11950
022592 [ts=176499968us, mod=100 level=1] scan: restarted scan procedure

AFTER

007634 [ts=59640584us, mod=100 level=1] scan: completed scan procedure, delta=1310
008946 [ts=69890568us, mod=100 level=1] scan: completed scan procedure, delta=1310
010258 [ts=80140616us, mod=100 level=1] scan: completed scan procedure, delta=1310
011570 [ts=90390600us, mod=100 level=1] scan: completed scan procedure, delta=1310
012882 [ts=100640584us, mod=100 level=1] scan: completed scan procedure, delta=1310
014194 [ts=110890568us, mod=100 level=1] scan: completed scan procedure, delta=1310
015506 [ts=121140616us, mod=100 level=1] scan: completed scan procedure, delta=1310
016818 [ts=131390600us, mod=100 level=1] scan: completed scan procedure, delta=1310
018130 [ts=141640584us, mod=100 level=1] scan: completed scan procedure, delta=1310

@vrahane vrahane changed the title controller/ble_ll_scan: For callouts number of ticks are used controller/ble_ll_scan: For callouts number of ticks should be used Aug 10, 2021
Copy link
Contributor

@rymanluk rymanluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this looks like regression after #1007

@vrahane vrahane merged commit e49a145 into apache:master Aug 11, 2021
@vrahane vrahane deleted the nimble_scanning_fix branch August 11, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants