nimble/host: Add HCI Commands/ events for connection subrating #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sjanc , this PR attempts to add host side support for Connection Subrating feature. Can you please take a look ? |
rahult-github
force-pushed
the
feature/host_commands_events_for_connection_subrating
branch
4 times, most recently
from
7127114
to
cf8c925
Compare
andrzej-kaczmarek
requested changes
Oct 4, 2022
rahult-github
force-pushed
the
feature/host_commands_events_for_connection_subrating
branch
from
cf8c925
to
a8161cb
Compare
sjanc
reviewed
Oct 4, 2022
rahult-github
force-pushed
the
feature/host_commands_events_for_connection_subrating
branch
2 times, most recently
from
cef1490
to
e8fbcf9
Compare
Thanks for this input. Yes, i missed making it configurable. Have added the change now. |
|
looks like change to nimble/syscfg.yml is missing |
|
LL will use |
rahult-github
force-pushed
the
feature/host_commands_events_for_connection_subrating
branch
from
e8fbcf9
to
cea7c54
Compare
|
The changes for macro name change and including in syscfg.xml are now pushed. Also changed the coding style issue reported in previous commit. |
rahult-github
force-pushed
the
feature/host_commands_events_for_connection_subrating
branch
from
cea7c54
to
7b61e1f
Compare
Style check summaryNo suggestions at this time! |
sjanc
approved these changes
Oct 5, 2022
andrzej-kaczmarek
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for HCI commands and events in stack for Connection subrating feature.