-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nimble/host: Update existing bond while re-pairing #1473
Conversation
continue; | ||
} | ||
} | ||
|
||
if (key_sec->idx > skipped) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also not needed since we can have only one set of keys for device (unlike cccd)
also remove all unused members from ble_store_key_sec structure (everything except peer_addr)
48f248f
to
f61f142
Compare
#AutoPTS run mynewt |
Scheduled PR ##1473 (comment) after 20:05:50. |
Scheduled PR ##1473 (comment) after 10:08:04. |
5e734c0
to
93e4832
Compare
AutoPTS Bot results: |
a51a318
to
ea4a1f0
Compare
While re-pairing ble_store_config_find_sec function was checking peer address, ediv and random number. Even if peer address was the same, the bond could be recognized as not the one we was looking for, because ediv and random number could be different. This was causting issues when the BLE_STORE_MAX_BONDS syscfg val was used. Re-pairing to the same device was treated as pairing to the new device and if current number of bonds was the same as BLE_STORE_MAX_BONDS, the re-pairing was failing.
#AutoPTS run mynewt |
Scheduled PR ##1473 (comment) after 10:31:06. |
AutoPTS Bot results: |
While re-pairing ble_store_config_find_sec function was checking peer address, ediv and random number. Even if peer address was the same, the bond could be recognized as not the one we was looking for, because ediv and random number could be different. This was causing issues when the BLE_STORE_MAX_BONDS syscfg val was used. Re-pairing to the same device was treated as pairing to the new device and if current number of bonds was the same as BLE_STORE_MAX_BONDS, the re-pairing was failing.