ll: Rework how TX power is configured #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
force-pushed
the
tx_power_on_tx_start
branch
from
5f97659
to
f9fb708
Compare
TX power is now always configured after channel (and PHY) is set before transmission is started. There is no "default" TX power and all users are expected to set it explicitly before transmission. This means that at the end of advertising TX power is not set back to global value. Main rationale for this change is to properly handle FEM that may have amplification factor depends on signal frequency (channel used).
This is useful for dynamic FEM drivers.
sjanc
force-pushed
the
tx_power_on_tx_start
branch
from
f9fb708
to
006b254
Compare
andrzej-kaczmarek
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.