nimble: Allow to configure BLE version 5.4 #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds configuration for Core Specification 5.4
KKopyscinski
force-pushed
the
core_spec_v54
branch
from
18491b3
to
9ee3488
Compare
|
why 5.3 is not enough for bttester? afaik we do not support any 5.4 feature. |
|
@andrzej-kaczmarek I just set the highest possible, but it makes sense to set at least 5.3, because for example periodic advertising belongs there |
Bump bttester version up so BLE 5.3 features can be used.
KKopyscinski
force-pushed
the
core_spec_v54
branch
from
625b4c7
to
a6e6fe5
Compare
|
I'd stick to 5.3 to make sure we are compliant, then check if 5.4 is just a matter of bumping version or there are some erratas that we are missing for 5.4 compliance. |
andrzej-kaczmarek
approved these changes
May 31, 2023
sjanc
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration for Core Specification 5.4