mesh: Fix GATT Proxy behavior to match Mesh Profile Spec 1.0.1 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed."
|
|
||
| rx.local_match = (bt_mesh_fixed_group_match(rx.ctx.recv_dst) || | ||
| bt_mesh_elem_find(rx.ctx.recv_dst)); | ||
| if (bt_mesh_gatt_proxy_get() == BT_MESH_GATT_PROXY_DISABLED && |
There was a problem hiding this comment.
"If the Proxy feature is disabled, a GATT client device can connect
over GATT to that node for configuration and control. Messages from
the GATT bearer are not relayed to the advertising bearer."
I'm not 100% sure if this means we should drop messages that are not directed at us or that we just shouldn't relay messages to ADV (see bt_mesh_net_relay() call below).
|
@jhedberg FYI |
|
@trond-snekvik we'll need to check if these fixes are applicable to Zephyr |
trond-snekvik
added a commit
to trond-snekvik/zephyr
that referenced
this pull request
Feb 13, 2020
Backport of apache/mynewt-nimble#724 Mesh spec 1.0.1 changes proxy disabling behavior to only affect the relaying from proxy nodes. Previously, disabling proxy would shut down all proxy and node activity. Tweaks from the original commit: - Removed redundant call to bt_mesh_adv_update() in gatt_proxy_set() - Removed invalid ref to 4.2.11.1 in node_identity_set() --- According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed." Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
jhedberg
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Feb 14, 2020
Backport of apache/mynewt-nimble#724 Mesh spec 1.0.1 changes proxy disabling behavior to only affect the relaying from proxy nodes. Previously, disabling proxy would shut down all proxy and node activity. Tweaks from the original commit: - Removed redundant call to bt_mesh_adv_update() in gatt_proxy_set() - Removed invalid ref to 4.2.11.1 in node_identity_set() --- According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed." Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
May 14, 2020
Backport of apache/mynewt-nimble#724 Mesh spec 1.0.1 changes proxy disabling behavior to only affect the relaying from proxy nodes. Previously, disabling proxy would shut down all proxy and node activity. Tweaks from the original commit: - Removed redundant call to bt_mesh_adv_update() in gatt_proxy_set() - Removed invalid ref to 4.2.11.1 in node_identity_set() --- According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed."
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
May 15, 2020
Backport of apache/mynewt-nimble#724 Mesh spec 1.0.1 changes proxy disabling behavior to only affect the relaying from proxy nodes. Previously, disabling proxy would shut down all proxy and node activity. Tweaks from the original commit: - Removed redundant call to bt_mesh_adv_update() in gatt_proxy_set() - Removed invalid ref to 4.2.11.1 in node_identity_set() --- According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed."
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
May 19, 2020
Backport of apache/mynewt-nimble#724 Mesh spec 1.0.1 changes proxy disabling behavior to only affect the relaying from proxy nodes. Previously, disabling proxy would shut down all proxy and node activity. Tweaks from the original commit: - Removed redundant call to bt_mesh_adv_update() in gatt_proxy_set() - Removed invalid ref to 4.2.11.1 in node_identity_set() --- According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed."
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jun 15, 2020
Backport of apache/mynewt-nimble#724 Mesh spec 1.0.1 changes proxy disabling behavior to only affect the relaying from proxy nodes. Previously, disabling proxy would shut down all proxy and node activity. Tweaks from the original commit: - Removed redundant call to bt_mesh_adv_update() in gatt_proxy_set() - Removed invalid ref to 4.2.11.1 in node_identity_set() --- According to Mesh Profile Spec 1.0.1, Section 4.2.11: "If the Proxy feature is disabled, a GATT client device can connect over GATT to that node for configuration and control. Messages from the GATT bearer are not relayed to the advertising bearer." Moreover some notes have been removed from the spec compared to version 1.0: Mesh Profile Spec 1.0, Section 4.2.11: "Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00 the GATT Bearer Server shall disconnect all GATT Bearer Clients." "The Configuration Client should turn off the Proxy state as the last step in the configuration process." Mesh Profile Spec 1.0, Section 4.2.11.1: "When the GATT Proxy state is set to 0x00, the Node Identity state for all subnets shall be set to 0x00 and shall not be changed."
|
Thanks, @LingaoM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Mesh Profile Spec 1.0.1, Section 4.2.11:
"If the Proxy feature is disabled, a GATT client device can connect
over GATT to that node for configuration and control. Messages from
the GATT bearer are not relayed to the advertising bearer."
Moreover some notes have been removed from the spec compared to
version 1.0:
Mesh Profile Spec 1.0, Section 4.2.11:
"Upon transition from GATT Proxy state 0x01 to GATT Proxy state 0x00
the GATT Bearer Server shall disconnect all GATT Bearer Clients."
"The Configuration Client should turn off the Proxy state as the last
step in the configuration process."
Mesh Profile Spec 1.0, Section 4.2.11.1:
"When the GATT Proxy state is set to 0x00, the Node Identity state
for all subnets shall be set to 0x00 and shall not be changed."