New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donating core DukeScript presenters to Apache NetBeans #23
Donating core DukeScript presenters to Apache NetBeans #23
Conversation
|
Re. the travis failures - the build was failing in master as well - fixed in 75e792f - please merge and re-try. |
browser/src/test/java/com/dukescript/presenters/BrowserTest.java
Outdated
Show resolved
Hide resolved
Hi, I think we must go through https://incubator.apache.org/ip-clearance/ process. |
I think it’s just like any other code that anyone else has written for Apache NetBeans. |
@ebarboni maybe bring that up as a general discussion point on dev@ ? Reading the link I think you have a point. On the other hand, we've integrated far bigger contributions by PR already without doing that. |
IT come to my mind because dukescript is like codehaus , and we had to do the IP clearance to be able to take over. Not sure others PR where in this case. |
It’s the same as Payara or Kotlin — simply a pull request is all that was done, just like any code contribution. |
@geertjanw those are two of the PRs I'm thinking of that judging from @ebarboni link should possibly also have gone through IP clearance. Still suggest we discuss on dev@ so we have a consistent approach on this, rather than here. |
Sounds good, I'll agree either way we decide. :-) |
6887a1e
to
c206ac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure .sigtest
artifact is generated for new projects.
… generate new .sigfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the technical side of the contribution. @ebarboni, once you are fine with legal aspects, please press the merge button.
@JaroslavTulach voting for acceptance started. mailed @dukescript to see if a Software Grant is applicable. |
@JaroslavTulach, @dukescript |
Hi @JaroslavTulach @dukescript , I'm not very good at PR management is it somehow possible to make this PR only one commit to help having just one hash to facilitate donation review ? |
I am not fan of squashing, especially if the only reason is legal. Just use the last hash: |
ok thanks, I guess the hash is enough |
@JaroslavTulach you can merge at any time, IP clearance vote pass |
This is a pull request that donates the core DukeScript presenters to HTML/Java subproject of Apache NetBeans. Following modules are being donated:
render
- a way to start a browser - using nativeGTK
(on Linux and Mac OS X), AWT or CLIgeneric
-ProtoPresenterBuilder
& co. - core implementation of a presenter that handles connection between JavaScript VM and Java VM via a textual protocol - very portablebrowser
- uses ofProtoPresenterBuilder
to start a local server and let a browser connect to itwebkit
- native presenter for Linux and Mac OS X that uses WebKit via JNACertain functionality in Apache NetBeans requires HTML/Java and that right now needs JavaFX. With the help of these presenters, the dependency on JavaFX could be made optional.
There was an interest in the Apache NetBeans community to create a presenter that would display inside of VSCode - the
browser
presenter should be enough for such task.