Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donating core DukeScript presenters to Apache NetBeans #23

Merged
merged 18 commits into from
Oct 21, 2019

Conversation

dukescript
Copy link
Contributor

This is a pull request that donates the core DukeScript presenters to HTML/Java subproject of Apache NetBeans. Following modules are being donated:

  • render - a way to start a browser - using native GTK (on Linux and Mac OS X), AWT or CLI
  • generic - ProtoPresenterBuilder & co. - core implementation of a presenter that handles connection between JavaScript VM and Java VM via a textual protocol - very portable
  • browser - uses of ProtoPresenterBuilder to start a local server and let a browser connect to it
  • webkit - native presenter for Linux and Mac OS X that uses WebKit via JNA

Certain functionality in Apache NetBeans requires HTML/Java and that right now needs JavaFX. With the help of these presenters, the dependency on JavaFX could be made optional.

There was an interest in the Apache NetBeans community to create a presenter that would display inside of VSCode - the browser presenter should be enough for such task.

@neilcsmith-net
Copy link
Member

👍 Thank you for doing this! You might be my new best friend. 😄 I'd recently been considering (again) whether to look at reimplementing these under Apache.

@jtulach
Copy link
Contributor

jtulach commented Sep 29, 2019

Re. the travis failures - the build was failing in master as well - fixed in 75e792f - please merge and re-try.

browser/pom.xml Outdated Show resolved Hide resolved
@ebarboni
Copy link
Contributor

Hi, I think we must go through https://incubator.apache.org/ip-clearance/ process.

@geertjanw
Copy link
Member

I think it’s just like any other code that anyone else has written for Apache NetBeans.

@neilcsmith-net
Copy link
Member

@ebarboni maybe bring that up as a general discussion point on dev@ ? Reading the link I think you have a point. On the other hand, we've integrated far bigger contributions by PR already without doing that.

@ebarboni
Copy link
Contributor

IT come to my mind because dukescript is like codehaus , and we had to do the IP clearance to be able to take over. Not sure others PR where in this case.

@geertjanw
Copy link
Member

It’s the same as Payara or Kotlin — simply a pull request is all that was done, just like any code contribution.

@neilcsmith-net
Copy link
Member

@geertjanw those are two of the PRs I'm thinking of that judging from @ebarboni link should possibly also have gone through IP clearance. Still suggest we discuss on dev@ so we have a consistent approach on this, rather than here.

@geertjanw
Copy link
Member

Sounds good, I'll agree either way we decide. :-)

Copy link
Contributor

@jtulach jtulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure .sigtest artifact is generated for new projects.

pom.xml Outdated Show resolved Hide resolved
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the technical side of the contribution. @ebarboni, once you are fine with legal aspects, please press the merge button.

@ebarboni
Copy link
Contributor

ebarboni commented Oct 3, 2019

@JaroslavTulach voting for acceptance started. mailed @dukescript to see if a Software Grant is applicable.

@ebarboni
Copy link
Contributor

ebarboni commented Oct 9, 2019

@JaroslavTulach, @dukescript
is the following page correct to your point of view ?
http://incubator.apache.org/ip-clearance/netbeans-dukescript-presenters.html

@ebarboni
Copy link
Contributor

Hi @JaroslavTulach @dukescript , I'm not very good at PR management is it somehow possible to make this PR only one commit to help having just one hash to facilitate donation review ?
All paperwork are set, just this final move may help tracability

@JaroslavTulach
Copy link

I am not fan of squashing, especially if the only reason is legal. Just use the last hash:
383122e it uniquely identifies all the previous history - in case you want to see changes, invoke git diff -r 75e792f9b2...383122e.

@ebarboni
Copy link
Contributor

ok thanks, I guess the hash is enough

@ebarboni
Copy link
Contributor

@JaroslavTulach you can merge at any time, IP clearance vote pass

@JaroslavTulach JaroslavTulach merged commit 6ef2915 into apache:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants