Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBeans 13 / JDK 17 support. #2

Closed
wants to merge 1 commit into from
Closed

Conversation

mbien
Copy link
Member

@mbien mbien commented Feb 7, 2022

WIP - needs a better solution for the --add-opens, since it would require to sync them on all archetypes, CI configs, nb.configs etc.

assumes apache/netbeans-mavenutils-nbm-maven-plugin#19 is integrated

@ebarboni
Copy link
Contributor

ebarboni commented Feb 9, 2022

@mbien I think it would be better to add all the add-opens stuff in a properties like the encoding one.
and use ${myaddopensproperties}.

it's possible for users to add additionArguments to nbm plugin configuration that need the add-openstuffs and copy pasting this long list may lead to desync.

@mbien
Copy link
Member Author

mbien commented Feb 9, 2022

@ebarboni agreed. But as I wrote in the PR description (and dev mail), we would need that list in all three archetypes, the NB config (its already duplicated in nb.conf) and also in the CI config for NB once JDK 17 testing starts.

I was thinking about adding it directly to the main netbeans repo to have it in a central place. The archetype projects would download it somehow during build? What do you think?

@ebarboni
Copy link
Contributor

ebarboni commented Feb 9, 2022

overheating :) . Sorry a bit long

I see several patch to the list of add-opens over the months, so maybe we can add an entry to https://github.com/apache/netbeans-jenkins-lib/blob/master/meta/netbeansrelease.json to get the add-opens stuff there for now in the master section patch the nbbuild to rewrite using this info so on NetBeans14 we can copy the list to lock the list to the build.
Thats cover the release process and also the CI I guess as it maybe read from json, having the nb.conf up todate.

We could just add a property in https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/blob/master/src/main/resources/META-INF/maven/archetype-metadata.xml to add a addopenslist properties defaulting to blank with some info around it
could land to

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<addopens.list></addopens.list>

1)I use this archetype within maven only I will have <addopens.list></addopens.list>
2) I use this archetype withing NetBeans and we can pass the addopenlist of the current NetBeans we use ( if we put the branding somewhere if the maven.apisupport module for https://github.com/apache/netbeans/blob/master/apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java to use )

@mbien
Copy link
Member Author

mbien commented Jul 9, 2024

closing in favor of #23

@mbien mbien closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants