remove usage of IOUtil.close #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
approved these changes
Feb 21, 2024
mbien
reviewed
Feb 21, 2024
| InputStream instream = null; | ||
| OutputStream output = null; | ||
| try | ||
| try (InputStream instream = getClass().getClassLoader().getResourceAsStream( path ); OutputStream output = new BufferedOutputStream( new FileOutputStream( destSh ) )) |
There was a problem hiding this comment.
split in two lines maybe?
try (InputStream instream = getClass().getClassLoader().getResourceAsStream(path);
OutputStream output = new BufferedOutputStream(new FileOutputStream(destSh))) {
mbien
reviewed
Feb 21, 2024
Comment on lines
649
to
650
| try ( Reader source = new BufferedReader( new InputStreamReader( instream, "UTF-8" ) ); Writer destination = new OutputStreamWriter( outstream, "UTF-8" ); ) | ||
| { |
There was a problem hiding this comment.
try (Reader source = new BufferedReader(new InputStreamReader(instream, "UTF-8"));
Writer destination = new OutputStreamWriter(outstream, "UTF-8")) {
|
I will do on two line. I think I will have nervous breakdown and autoformat all and do a no op push to have in native NetBeans format like nb-pakage. |
|
NB can format code sections. You select something and format. |
ebarboni
force-pushed
the
depreactionfixes
branch
from
a1da38c
to
54859d9
Compare
|
Yep but changing for new code will make the source a patchwork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove deprecation and use try with resources to get rid of this old code