Fix InvalidPathException issue on Windows in FileUtils::findDirs #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Util::findDirs Using Path is OS specific, and Windows doesn't support use of glob wilcard * in paths. Instead, do String::split on /. Also update documentation in line with the requirements.
mbien
approved these changes
May 30, 2023
ebarboni
approved these changes
May 31, 2023
|
Thanks @ebarboni Is the Jenkins JDK the JDK that builds snapshots? Should keep 11 for main build. |
Or stupid programmer! 😆 Given how many other things in this were written to be careful of cross-OS issues, this was a daft mistake. I intend to do a bit more Windows testing before we release beta3. Thanks @mbien |
jdk8 build snapshot for default Apache Maven NetBeans related but for nbpackage the jdk is jdk11. overrided in the Jenkins.groovy file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileUtils::findDirs is breaking on Windows as it's using
Pathto calculate the max path depth for the passed in glob patterns, and*is not supported in a Windows path. Switches to usingString::split.First commit adds a workflow matrix to build and run unit tests on Linux, Windows and macOS.
Fixes #28