Support arch option for building Swift launcher #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime filename when present.
neilcsmith-net
force-pushed
the
macos-arch
branch
from
1e82b85
to
7fc49b0
Compare
|
I cannot test on mac. |
|
@ebarboni yes, thanks, wasn't sure but had a feeling you didn't have access to a mac. Hopefully @mcdonnell-john or @oyarzun could take a quick look, but if not will rely on feedback on the test installers, and merge this in next few days. |
|
@neilcsmith-net I've been on vacation, so I haven't had a chance to test it. But the code looks sane to me. |
|
OK, thanks @oyarzun I'll merge this PR. If you get a chance to look at / evaluate the test installer at apache/netbeans#6052 (comment) and feedback on the dev@ thread that would be great. We need to make a decision soon whether to move to this for the NB19 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an arch option for building Swift launcher, to allow for building as x64, arm64 and universal binary.
If the option is left blank, defaults to universal if no runtime is present, else attempts to parse from the runtime (eg. JDK) filename.
As well as supporting an IDE or RCP installer with Apple Silicon JDK, this can potentially address concerns with ASF installer in apache/netbeans#6052