Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven Wrapper (only-script) configured to use Maven 3.9.3. #38

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

neilcsmith-net
Copy link
Member

Add Maven Wrapper configured to use Maven 3.9.3.

  • Ran mvn wrapper:wrapper -Dmaven=3.9.3 -Dtype=only-script
  • Manually added SHA256
  • Updated workflow to use wrapper

@neilcsmith-net
Copy link
Member Author

I'd forgotten the "linux" build workflow is now cross-platform, but seems Windows Powershell is working fine with that syntax anyway ..

@ebarboni
Copy link
Contributor

LGTM

@neilcsmith-net neilcsmith-net merged commit 8a94ba0 into apache:master Jul 27, 2023
6 checks passed
@mbien
Copy link
Member

mbien commented Jul 27, 2023

the maven wrapper script is actually pretty cool, it even uses a java single-file-program as fallback download option :)

@neilcsmith-net
Copy link
Member Author

@mbien yes, saw that - hadn't looked at the new script option until last week when adding mvnw to another project. Some interesting things in there, although with a few caveats for now. The Windows one might also be interesting to look at - I wonder if a batch to powershell launcher option could work for the IDE?

@mbien
Copy link
Member

mbien commented Jul 29, 2023

I wonder if a batch to powershell launcher option could work for the IDE?

worth a try. Esp since old systems like win 7 are essentially gone now. I remember that starting programs via scripts on old windows systems had problems like not being able to close the command prompt or having it pop up for a split second etc. I bet those issues are solved by now - not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants