Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlatLaf from 1.6.1 to 2.0 #3445

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

DevCharly
Copy link
Member

Update FlatLaf to v2: https://github.com/JFormDesigner/FlatLaf/releases/tag/2.0

There are (nearly) no visual differences compared to previous used version, except the slightly changed check boxes and radio buttons.

The main benefits of FlatLaf v2 for NetBeans are the reworked core themes (easier changing colors), the possibility to change the accent color and the FlatLaf Theme Editor. This should it make it relative easy to change colors/style of the light and dark themes to differentiate more from IntelliJ IDEA look.

E.g. adding following to platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLightLaf.properties

@background = #f3f3f3
@accentColor = #007aff

would change the look to (blue accent color; background minimally lighter):

image

Or adding following to platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatDarkLaf.properties

@background = #333
@foreground = #c4c4c4
@accentColor = darken(#007aff,5%)

Button.default.foreground = #ddd

would make NetBeans darker and give text more contrast:

image

Not sure how to "organize" work/ideas on such theme changes...
Maybe create two "Draft PRs" (for light and dark) where interested people can comment and add commits?

@mbien
Copy link
Member

mbien commented Jan 11, 2022

nice!

Regarding the theme adjustments and feedback: You could combine a draft PR with a forum thread since its probably easier to post images there compared to mailing lists.

@neilcsmith-net
Copy link
Member

+1 Nice!

Putting NB13 milestone on this.

Now just need to convince @eirikbakke of the merits of CSS styling SVG icons to pick up the accent colour! 😄

@neilcsmith-net neilcsmith-net added this to the NB13 milestone Jan 12, 2022
@eirikbakke eirikbakke self-requested a review January 12, 2022 12:14
Copy link
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to hear of the FlatLAF 2.0 release!

(@neilcsmith-net My NetBeans Platform app actually uses accent colors already! Except prior to FlatLAF 2.0, I had to set 80 different FlatLAF properties for this. The main reason I don't try to do it with icons is because the existing NetBeans icon style is multi-colored, and not duotone.)

@neilcsmith-net
Copy link
Member

@eirikbakke at no point have I suggested switching to duotone icons in order to integrate with this change! You keep saying I have. Let's leave the practicalities of that discussion on dev@, but let's also tie in to what @DevCharly says about organizing ideas on theme changes.

@eirikbakke
Copy link
Contributor

@neilcsmith-net Yeah, sorry, we can continue the thread on dev... :-)

@mbien mbien added Look and Feel Upgrade Library Library (Dependency) Upgrade labels Jan 15, 2022
@mbien
Copy link
Member

mbien commented Jan 17, 2022

this seems to be a fairly uncontroversial lib update, lets merge this for NB13.

@neilcsmith-net neilcsmith-net merged commit b4e2ce1 into apache:master Jan 17, 2022
@DevCharly DevCharly deleted the flatlaf-2.0 branch January 17, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and Feel Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants