Hint: “Convert Explicit Type to Var” shouldn’t be reported for method references or lambda expressions

[ExE-Boss]

Apache NetBeans version

Latest release

What happened

Convert Explicit Type to Var is reported for method references and lambda expressions, e.g.:

final Consumer<String> println = System.out::println;

But it's invalid to replace the above with:

final var println = System.out::println;

which results in the compile error:

error: cannot infer type for local variable println
final var println = System.out::println;
          ^
  (method reference needs an explicit target-type)

How to reproduce

See above

Did this work correctly in an earlier version?

• This used to work!

Operating System

Windows 10

JDK

OpenJDK Runtime Environment Temurin-17.0.1+12 (build 17.0.1+12)

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

No response

Are you willing to submit a pull request?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow the Apache Software Foundation's Code of Conduct

[neilcsmith-net]

Thanks for the report. Can reproduce. Definitely a bug.

[mbien]

the hint is here:
https://github.com/apache/netbeans/blob/master/java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java

potentially easy to fix. But maybe someone else can do it since I don't use 'var' at all :)

adding the good-first-issue label.