PHP 8.1 backed enumerations implementation

[adamturcsan]

Description

NB 14 has support for the new features of php 8.1, but the enumeration support has a deficiency.

Enumerations cannot have properties (which is important as those are objects in the language implementation) although there is a use case, where an enumeration can have one, and only one readonly public property, called value.

This property is populated when backed enumerations are used.

Use case/motivation

Right now NB shows an error when a property on an enumeration is accessed. The error is context dependant, an example code is below:

<?php

use DateTimeImmutable;
use DateTimeZone;

enum StopDay: string
{
    case WEEKDAYS = 'weekdays';
    case WEEKEND = 'weekend';
    case MONDAY = 'Mon';
    case TUESDAY = 'Tue';
    case WEDNESDAY = 'Wed';
    case THURSDAY = 'Thu';
    case FRIDAY = 'Fri';
    case SATURDAY = 'Sat';
    case SUNDAY = 'Sun';

    public function isToday(DateTimeImmutable $date = new DateTimeImmutable('now', new DateTimeZone('UTC'))): bool
    {
        return match($this) {
            self::MONDAY => $date->format('D') === self::MONDAY->value,
            self::TUESDAY => $date->format('D') === self::TUESDAY->value,
            self::WEDNESDAY => $date->format('D') === self::WEDNESDAY->value,
            self::THURSDAY => $date->format('D') === self::THURSDAY->value,
            self::FRIDAY => $date->format('D') === self::FRIDAY->value,
            self::SATURDAY => $date->format('D') === self::SATURDAY->value,
            self::SUNDAY => $date->format('D') === self::SUNDAY->value,
            self::WEEKDAYS => $date->format('D') !== self::SATURDAY->value && $date->format('D') !== self::SUNDAY->value,
            self::WEEKEND => $date->format('D') === self::SATURDAY->value || $date->format('D') === self::SUNDAY->value
        };
    }
}

In the example below, after every ->value there's a Syntax error, because the checker expects a method call. So in this case line 21. shows an error:

Syntax error:
    unexpected: ,
    expected: (

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow the Apache Software Foundation's Code of Conduct