Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer vendor name containing a dot or an underscore is not accepted #6192

Closed
ChristianJohn-Softwareentwicklung opened this issue Jul 13, 2023 · 1 comment · Fixed by #6196
Closed

Composer vendor name containing a dot or an underscore is not accepted #6192

ChristianJohn-Softwareentwicklung opened this issue Jul 13, 2023 · 1 comment · Fixed by #6196
Assignees
@junichi11
Labels
kind:bug Bug report or fix PHP [ci] enable extra PHP tests (php/php.editor)
Milestone
NB19

Comments

@ChristianJohn-Softwareentwicklung
Copy link

Apache NetBeans version

Apache NetBeans 18

What happened

While setting up composer in options, my vendor name throws a note
Vendor is not valid (only lower-case letters and "-" allowed).
I am able to save my settings, but when do a composer init the option window is open again.

image

How to reproduce

Go to options, PHP, Composer.
Set a vendor name like my-vendor.com

Did this work correctly in an earlier version?

No / Don't know

Operating System

Windows 10

JDK

1.8.0_131; Java HotSpot(TM) 64-Bit Server VM 25.131-b11

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

Refering to https://getcomposer.org/doc/04-schema.md since composer 2.0 dots and underscores are allowed.
"The name must be lowercase and consist of words separated by -, . or _. The complete name should match ^a-z0-9/a-z0-9$

Note: Before Composer version 2.0, a name could contain any character, including white spaces."

At the composer console "my-vendor.com" is working.

Are you willing to submit a pull request?

No
@ChristianJohn-Softwareentwicklung ChristianJohn-Softwareentwicklung added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Jul 13, 2023
@mbien mbien added the PHP [ci] enable extra PHP tests (php/php.editor) label Jul 13, 2023
@junichi11 junichi11 self-assigned this Jul 13, 2023
@junichi11 junichi11 removed the needs:triage Requires attention from one of the committers label Jul 13, 2023
@junichi11
Copy link
Member

@ChristianJohn-Softwareentwicklung Thank you for reporting it!

@junichi11 junichi11 added this to the NB19 milestone Jul 13, 2023
junichi11 added a commit to junichi11/netbeans that referenced this issue Jul 14, 2023
@junichi11
Fix the vendor name regex for Composer apache#6192
cd3bc27 
- apache#6192
- https://getcomposer.org/doc/04-schema.md#name
- VendorName/PackageName: `^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]|-{1,2})?[a-z0-9]+)*$`
@junichi11 junichi11 mentioned this issue Jul 14, 2023
Merged
@junichi11 junichi11 linked a pull request Jul 14, 2023 that will close this issue
Fix the vendor name regex for Composer #6192 #6196
Merged
junichi11 added a commit that referenced this issue Jul 14, 2023
@junichi11
Merge pull request #6196 from junichi11/php-gh-6192-composer-vendor-name
595fa2c 
Fix the vendor name regex for Composer #6192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junichi11 junichi11

Labels
kind:bug Bug report or fix PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB19
Development

Successfully merging a pull request may close this issue.

Fix the vendor name regex for Composer #6192 junichi11/netbeans
3 participants
@mbien @junichi11 @ChristianJohn-Softwareentwicklung