Create empty war for application on the fly #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty.war was originally created by the build script, then it was committed to the repository (assumed accidentally). Instead of building the war at build time or putting it into the repository, this patch moves creation to runtime.
|
@geertjanw please have a look at this. The The easiest fix would have been to just remove empty.war again and add it to .gitignore, but I think building the war at runtime ensures, that there is no file, that can be accidentally committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty.war was originally created by the build script, then it was
committed to the repository (assumed accidentally). Instead of building
the war at build time or putting it into the repository, this patch
moves creation to runtime.