Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2315] Switch expression multi cases should have Enum values… #1175

Merged

Conversation

@vikasprabhakar
Copy link
Contributor

commented Mar 27, 2019

… in auto complete options
The multi cases in switch expression should show the enum value in auto complete options:

Example:

enum state {CANCELLED, INTERRUPTING, INTERRUPTED, NORMAL , EXCEPTIONAL}

String status = switch (state) {
case NORMAL -> "[Completed normally]";
case EXCEPTIONAL, -> "[Completed exceptionally: " + outcome + "]";

The auto complete option at should contain the enum value of {CANCELLED, INTERRUPTING, INTERRUPTED}

@vikasprabhakar vikasprabhakar force-pushed the vikasprabhakar:auto_complete_switch_expression branch from 37af404 to 68f21ee Mar 29, 2019

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@arusinha Vikas does not have committer status, so he can't merge the changeset himself. On github the status of the person requesting the merge is quickly visible in header of the PR comment. Compare yours (notice the "Member" entry) to Vikas "Contributor". In this case I'd advise to merge after you approved.

This assumes of course, that you are not waiting for a second review.

@arusinha arusinha merged commit 8fb84ee into apache:master Apr 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vikasprabhakar vikasprabhakar deleted the vikasprabhakar:auto_complete_switch_expression branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.